New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendorlist is called multiple times #206

Closed

SindreSvendby opened this issue Sep 4, 2018 · 1 comment · Fixed by #209

SindreSvendby commented Sep 4, 2018

It seems that there is a bug/racecondition, when you load several ads on page load.

When a page loads one ad, and on scroll triggers a new, then we only see one request to the vendorlist.

But when we load more then one ad on page load, we see one request pr ad.

This can be seen at https://www.seher.no/kjendis/ikke-min-skyld-at-ben-affleck-er-pa-rehab/70168240 on a medium size monitor.

Contributor

ptc commented Sep 5, 2018

We'll investigate it.

Fumler mentioned this issue

fix: Only request vendorlist once #209

Merged

marcelb closed this as completed in #209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment