Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poi_list URL is based on publicPath, not poi_hub_origin #239

Closed
mgolebiowski opened this issue Mar 6, 2019 · 2 comments
Closed

poi_list URL is based on publicPath, not poi_hub_origin #239

mgolebiowski opened this issue Mar 6, 2019 · 2 comments

Comments

@mgolebiowski
Copy link

When configuration contains publicPath and poi_hub_origin URL for poi_list is based on publicPath which is inconsistent with documentation [1].

How to reproduce:

Create configuration with publicPath with different URL than hub_origin. Oil will try to fetch POI List from __OIL_PUBLIC_PATH__ + 'poi-lists/' + groupName + '.json'[2]

How it should work:

POI List should be fetched from __POI_HUB_PATH__+'poi_lists/' + groupName + '.json'

[1] http://oil.axelspringer.com/docs/#poi-power-opt-in
[2]

fetchJsonData(__webpack_public_path__ + 'poi-lists/' + groupName + '.json')

@ptc
Copy link
Contributor

ptc commented Mar 18, 2019

We'll check it.

@ltparis2018
Copy link
Contributor

This problem is fixed with pull request #252. The poi-lists directory is based on poi_hub_origin now (but not on poi_hub_path - this points to an HTML file).
We plan to add this fix to our next OIL release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants