Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS] ASCII hydra - Add Automated Tests and Github Action to run it #11

Open
abhishektiwari opened this issue Feb 4, 2025 · 0 comments

Comments

@abhishektiwari
Copy link

abhishektiwari commented Feb 4, 2025

There are some tests under ascii_library_tests but not clear what is required to run these tests. Please add Github Action to run these tests. Integration or e2e tests are missing which is essential for a data pipeline package. Bare minimum, I suggest authors to automate the ascii_library_demo as e2e test which can be run on every commit or on-demand using a Github actions. Authors are more than welcome to add any additional manual or automated testing. So far I don't think this software meets the quality bar of JOSS and needs to improve.

For JOSS Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant