-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples for Java 21, add Kotlin DSL gradle example #143
base: main
Are you sure you want to change the base?
Conversation
I made some changes after opening, you should squash the commits in the UI and I'd probably include the "fixes #" in that message |
Thanks @xenoterracide! I'd rather remove duplication than add to it, we could remove |
yeah, fair, I don't know where that code lives (haven't looked), and we still need a kotlin DSL example. It can be quite different... and is now the default when you generate a gradle project. Yay that kotlin.dcl is coming so eventually you'll need a 3rd format too... that bridge isn't really ready to cross though. I don't know if that source has a way that allows you to select the language shown like gradle docs and some spring docs have, I'm guessing no. should I update this PR? and and/or send a new one to those docs? |
Totally my mistake for not linking. It's a bit nested in
I agree, it can be added next to the Gradle Groovy config for now. We could add "tabs" to the docs, but that needs to be done upstream in the docs aggregator repo. It's not something we can do autonomously now.
Updating this is fine, I can take take of the squash from UI also. thanks! |
Fixes #142
Fixes #107