-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Gradle examples to use version 2.0 of plugin #50
Comments
upvoting this. |
I agree this would be a valuable change. Unfortunately I don't have the time to work on this at the moment. If anyone would like to help out, please comment here and specify which sample you would like to update. We can do one sample at a time to make it a smaller task. |
Version 3.0.0 is out! https://github.com/asciidoctor/asciidoctor-gradle-plugin Is that OK @rwinch? |
That sounds great. Thank you @Mogztter |
@Mogztter I just branched the old code to 1.x and master should now be 3.x Perhaps a good approach would be to just get one sample working with the new plugin and temporarily delete the old samples. That way we get something working. What are your thoughts? |
You don't need to delete them, just exclude from settings.gradle. |
@slonopotamus I'm not sure what the buys us if they don't work. We can always recover them from the git history |
@rwinch Maybe we should publish the v1.x examples to: https://asciidoctor.github.io/asciidoctor-gradle-plugin/1.x/ and master to https://asciidoctor.github.io/asciidoctor-gradle-plugin/master/ ? I don't think we want to maintain a v2.x branch based on the Asciidoctor Gradle Plugin 2.x. |
I agree. At this point there seems little reason to put together a 2.x version of the plugins. For now, I'm closing this since we are working on 3.x. We can revisit this if there is sufficient demand for 2.x branch. |
I'm totally confused over how to run version 2.0 of the asciidoctor-gradle-plugin.
Please upgrade the examples to use 2.0.
Thanks
The text was updated successfully, but these errors were encountered: