Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle examples to use version 2.0 of plugin #50

Closed
ghost opened this issue Apr 3, 2019 · 9 comments
Closed

Upgrade Gradle examples to use version 2.0 of plugin #50

ghost opened this issue Apr 3, 2019 · 9 comments

Comments

@ghost
Copy link

ghost commented Apr 3, 2019

I'm totally confused over how to run version 2.0 of the asciidoctor-gradle-plugin.

Please upgrade the examples to use 2.0.

Thanks

@gAmUssA
Copy link

gAmUssA commented Jun 21, 2019

upvoting this.
2.0 has many significant changes it would be great to have updated examples

@rwinch
Copy link
Member

rwinch commented Jun 24, 2019

I agree this would be a valuable change. Unfortunately I don't have the time to work on this at the moment. If anyone would like to help out, please comment here and specify which sample you would like to update. We can do one sample at a time to make it a smaller task.

@ggrossetie
Copy link
Member

Version 3.0.0 is out! https://github.com/asciidoctor/asciidoctor-gradle-plugin
I will update the examples and add a new example to explain how to create a custom task: asciidoctor/asciidoctor-gradle-plugin#504

Is that OK @rwinch?

@rwinch
Copy link
Member

rwinch commented Jan 24, 2020

That sounds great. Thank you @Mogztter

@rwinch
Copy link
Member

rwinch commented Jan 24, 2020

@Mogztter I just branched the old code to 1.x and master should now be 3.x Perhaps a good approach would be to just get one sample working with the new plugin and temporarily delete the old samples. That way we get something working. What are your thoughts?

@slonopotamus
Copy link

You don't need to delete them, just exclude from settings.gradle.

@rwinch
Copy link
Member

rwinch commented Jan 24, 2020

@slonopotamus I'm not sure what the buys us if they don't work. We can always recover them from the git history

@ggrossetie
Copy link
Member

@rwinch Maybe we should publish the v1.x examples to: https://asciidoctor.github.io/asciidoctor-gradle-plugin/1.x/ and master to https://asciidoctor.github.io/asciidoctor-gradle-plugin/master/ ?

I don't think we want to maintain a v2.x branch based on the Asciidoctor Gradle Plugin 2.x.

@rwinch
Copy link
Member

rwinch commented Jan 27, 2020

I don't think we want to maintain a v2.x branch based on the Asciidoctor Gradle Plugin 2.x.

I agree. At this point there seems little reason to put together a 2.x version of the plugins. For now, I'm closing this since we are working on 3.x. We can revisit this if there is sufficient demand for 2.x branch.

@rwinch rwinch closed this as completed Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants