Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge effort with the PlantUML extension #41

Open
ggrossetie opened this issue Dec 14, 2018 · 3 comments
Open

Merge effort with the PlantUML extension #41

ggrossetie opened this issue Dec 14, 2018 · 3 comments

Comments

@ggrossetie
Copy link
Member

I can see that you are using an extension to render PlantUML diagrams. I think it would be great to merge our efforts in https://github.com/eshepelyuk/asciidoctor-plantuml.js

The main advantage is that the extension can be reused in many editor. For instance I'm using the PlantUML extension in the browser extension.

You could for instance contribute the missing "substitution feature" https://github.com/eshepelyuk/asciidoctor-plantuml.js/issues/38

What do you think ?

@mojavelinux
Copy link
Member

Keep in mind there's also the initiative to add a web-based API in asciidoctor-diagram, which would open up all of it's capabilities to Asciidoctor.js. See asciidoctor/asciidoctor-diagram#183.

@nerk
Copy link
Member

nerk commented Dec 15, 2018

@Mogztter I was already looking at that code to figure out if I could use it. It also tought me that there is an API to declare positional attributes. 👍

PlantUML is being invoked from within a JavaScript worker by the Brackets extension. I might be wrong, but I think asciidoctor-plantuml.js will have currently problems with that. For example, modules and require() won't work. That prevented me to directly use that code. But I fully agree, it would be great if this could be used.

@ggrossetie
Copy link
Member Author

@nerk The extension also produce a "browserified" version so it can be used in a browser environment. I'm not familiar with the brackets JavaScript environment but you should try the browser version. If it's not working we can adapt the code (much like Asciidoctor.js) to make it work in a bracket environment 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants