Skip to content

Commit dbf2beb

Browse files
desprdascopes
authored andcommitted
GH-824: Make HttpClientUrlConnection and HttpUrlStreamHandlerFactory classes final and package-private
1 parent 7f5b9f8 commit dbf2beb

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

protobuf-maven-plugin/src/main/java/io/github/ascopes/protobufmavenplugin/urls/HttpClientUrlConnection.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,13 @@
1616
package io.github.ascopes.protobufmavenplugin.urls;
1717

1818
import io.github.ascopes.protobufmavenplugin.utils.HttpRequestException;
19-
import java.io.ByteArrayInputStream;
2019
import java.io.FileNotFoundException;
2120
import java.io.IOException;
2221
import java.io.InputStream;
2322
import java.net.URISyntaxException;
2423
import java.net.URL;
2524
import java.net.URLConnection;
2625
import java.net.http.HttpClient;
27-
import java.net.http.HttpClient.Redirect;
28-
import java.net.http.HttpClient.Version;
2926
import java.net.http.HttpRequest;
3027
import java.net.http.HttpResponse;
3128
import java.net.http.HttpResponse.BodyHandlers;
@@ -38,13 +35,13 @@
3835
* @author Ilja Kanstanczuk
3936
* @since 3.10.1
4037
*/
41-
public class HttpClientUrlConnection extends URLConnection {
38+
final class HttpClientUrlConnection extends URLConnection {
4239

4340
private final HttpClient client;
4441
private final HttpRequest request;
4542
private HttpResponse<InputStream> response;
4643

47-
public HttpClientUrlConnection(URL url, HttpClient client) throws URISyntaxException {
44+
HttpClientUrlConnection(URL url, HttpClient client) throws URISyntaxException {
4845
super(url);
4946
this.client = client;
5047
this.request = HttpRequest

protobuf-maven-plugin/src/main/java/io/github/ascopes/protobufmavenplugin/urls/HttpUrlStreamHandlerFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
* @author Ilja Kanstanczuk
3131
* @since 3.10.1
3232
*/
33-
public class HttpUrlStreamHandlerFactory extends AbstractUrlStreamHandlerFactory {
33+
final class HttpUrlStreamHandlerFactory extends AbstractUrlStreamHandlerFactory {
3434

3535
private final HttpClient client;
3636

0 commit comments

Comments
 (0)