Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fortran-order arrays to be serialized #539

Merged
merged 3 commits into from
Sep 6, 2018

Conversation

drdavella
Copy link
Contributor

This fixes #538.

@drdavella drdavella added the bug label Sep 4, 2018
@drdavella drdavella added this to the v2.0.3 milestone Sep 4, 2018
@drdavella drdavella self-assigned this Sep 4, 2018
@stsci-bot
Copy link

stsci-bot bot commented Sep 4, 2018

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

2 similar comments
@stsci-bot
Copy link

stsci-bot bot commented Sep 4, 2018

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@stsci-bot
Copy link

stsci-bot bot commented Sep 4, 2018

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@coveralls
Copy link

coveralls commented Sep 4, 2018

Coverage Status

Coverage increased (+0.004%) to 93.868% when pulling c7487a1 on drdavella:fix-fortran-order into c44d92a on spacetelescope:master.

asdf/block.py Outdated
@@ -867,7 +870,7 @@ def _set_checksum(self, checksum):

def _calculate_checksum(self, data):
m = hashlib.new('md5')
m.update(self.data)
m.update(np.ascontiguousarray(self.data))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually might make more sense to just to m.update(self.data.flatten()) here.

@drdavella drdavella merged commit 6705cd6 into asdf-format:master Sep 6, 2018
@drdavella drdavella deleted the fix-fortran-order branch September 6, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fortran-layout arrays are handled wrong
2 participants