Allow installed extensions to be configured with AsdfConfig #847
Conversation
eslavich
force-pushed
the
eslavich-add-extension-config
branch
from
03e1f06
to
c900f3f
Compare
| self._extension_list = AsdfExtensionList(self.extensions) | ||
|
|
||
| return self._extension_list | ||
| return AsdfExtensionList(self.extensions) |
There was a problem hiding this comment.
This is exceedingly too clever for me. This class(?) property uses self.extensions, but the class has no init nor inherits from another class, and yet has that attribute? I need to catch up on my meta meta classes.
There was a problem hiding this comment.
The extensions property is still there! It's just obscured on GitHub by the ugly diff.
asdf/asdf/extension/_legacy.py
Lines 187 to 190 in c900f3f
| @@ -214,8 +247,10 @@ def _check_extensions(self, tree, strict=False): | |||
| return | |||
|
|
|||
| for extension in tree['history']['extensions']: | |||
| installed = next((e for e in self.extensions if e.class_name == extension.extension_class), None) | |||
There was a problem hiding this comment.
I guess I would prefer a bit more verbose construction than using next() to provide the default None. But that's just me.
There was a problem hiding this comment.
This will be changing in a future PR anyway, since the condition gets too complex for one line. I'll leave it alone for the moment.
This PR refactors the existing extension code to make the new API easier to implement. Changes include:
_DefaultExtensionsto the newasdf.entry_pointsmodule_DefaultExtensionstoAsdfConfig_DefaultExtensionsso that it becomes a thin interface aroundAsdfConfig