-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observe ASDF_CONCURRENCY #369
Comments
Hello, I run into this today, does this accept PR or maintained or whatever? |
I'm not sure I'm a fan of asdf managing the concurrency settings. What if a user wants to use different settings Ruby and another setting for another asdf plugin? In any case a user has to set something, either: export MAKE_OPTS="-j <cores>" export ASDF_CONCURENCY="<cores>" Thoughts? |
Hey @Stratus3D.
The official docs suggest that it should be supported: https://asdf-vm.com/manage/configuration.html#concurrency
If the plugins don't observe it, then there is no point in its existence, I suppose.
It should be as simple as you suggest, no? $ export ASDF_CONCURRENCY=<cores>
$ asdf install ruby To clarify why I'm asking about this setting. The default options set If major plugins such as asdf-ruby do not intend to support |
First of all, thank you for all the hard work so far.
I would like to inquire about support for
ASDF_CONCURRENCY
. Unless I'm missing something, it looks it was added in 77df296, but then got lost during the transition toruby-build
.Do you think we could reintroduce it by passing the value to
ruby-build
asMAKE_OPTS
? I'm hoping it is as simple as exporting before the build command:+export MAKE_OPTS="-j $ASDF_CONCURRENCY" echo "$patches" | "$(ruby_build_path)" ${opts} "$version" "$install_path"
The text was updated successfully, but these errors were encountered: