Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publicPath without http or https #61

Closed
AliasT opened this issue Sep 20, 2017 · 5 comments
Closed

publicPath without http or https #61

AliasT opened this issue Sep 20, 2017 · 5 comments

Comments

@AliasT
Copy link

AliasT commented Sep 20, 2017

when i set the publicPath without http or https, just like //s.bar.com/public,
path.join will make the final script tag src starts with /s.bar.com/public ,

https://github.com/asfktz/autodll-webpack-plugin/blob/v0.2.1/src/paths.js#L12

@panuruj
Copy link

panuruj commented Sep 21, 2017

Also, on Windows, the final path becomes backslashes instead of a slash.
publicPath: https://localhost/
result: https:\localhost\vendor.js

@tryggvigy
Copy link

@AliasT I opened a PR addressing this issue. #64

@tryggvigy
Copy link

@panuruj Since you have full control over webpack's publicPath and autodll-webpack-plugin's path keys. Can't you make sure they are valid URL fragments (only / delimiters and no \)? I think autodll-webpack-plugin will handle that correctly.

@tryggvigy
Copy link

Oh never mind! path.join on windows joins with a \, right? So it would be a problem on windows.

@asfktz
Copy link
Owner

asfktz commented Oct 15, 2017

Hi, @AliasT!

I released a new version (0.3.2) which should fix it.

Can you verify that the issue resolved? Thanks

@AliasT AliasT closed this as completed Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants