Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return_destroyed?: true destroy option not honoured by AshArchival. #1433

Closed
jimsynz opened this issue Sep 2, 2024 · 1 comment
Closed

return_destroyed?: true destroy option not honoured by AshArchival. #1433

jimsynz opened this issue Sep 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jimsynz
Copy link
Contributor

jimsynz commented Sep 2, 2024

Describe the bug

When calling Ash.destroy(archiveable_record, return_destroyed?: true) we simply receive :ok.

To Reproduce

Will open a repro PR

Expected behavior

Should receive the record with the archived_at attribute set.
@jimsynz jimsynz added the bug Something isn't working label Sep 2, 2024
jimsynz referenced this issue in ash-project/ash_archival Sep 2, 2024
@jimsynz
chore: reproduction for issue #57.
8c2e5c8
zachdaniel referenced this issue in ash-project/ash_archival Sep 2, 2024
@jimsynz
chore: reproduction for issue #57. (#58)
48e1029
@zachdaniel zachdaniel transferred this issue from ash-project/ash_archival Sep 2, 2024
@zachdaniel
Copy link
Contributor

This is a generalized issue of soft destroys not honoring return_destroyed?. Fixing in core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimsynz @zachdaniel