Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running the examples on the generator branch #136

Closed
SiebenCorgie opened this issue Nov 3, 2018 · 3 comments
Closed

Running the examples on the generator branch #136

SiebenCorgie opened this issue Nov 3, 2018 · 3 comments
Labels

Comments

@SiebenCorgie
Copy link

Hi,

I tried to run the examples on the generator branch but they fail:
with V1_0 I get

thread 'main' panicked at 'Unable to load swapchain: ["vkGetDeviceGroupPresentCapabilitiesKHR", "vkAcquireNextImage2KHR"]

and with V1_1 (changing every V1_0 to V1_1, but also including the traits for 1_0 from ash::version) I get the following error:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: LoadError(["vkBindBufferMemory2", "vkBindImageMemory2", "vkGetDeviceGroupPeerMemoryFeatures", "vkCmdSetDeviceMask", "vkCmdDispatchBase", "vkGetImageMemoryRequirements2", "vkGetBufferMemoryRequirements2", "vkGetImageSparseMemoryRequirements2", "vkTrimCommandPool", "vkGetDeviceQueue2", "vkCreateSamplerYcbcrConversion", "vkDestroySamplerYcbcrConversion", "vkCreateDescriptorUpdateTemplate", "vkDestroyDescriptorUpdateTemplate", "vkUpdateDescriptorSetWithTemplate", "vkGetDescriptorSetLayoutSupport"])',

which is worse as far as I can tell.
Am I doing something wrong or is this a regression/bug within the branch?

@MaikKlein
Copy link
Member

MaikKlein commented Nov 3, 2018

That is just a problem that I haven't addressed yet. I'll try to fix it tomorrow but I can't make any guarantees. Essentially I don't want to introduce versioning for extensions and ash will initialize functions that can't be loaded with a panicking function.

@MaikKlein MaikKlein added the bug label Nov 3, 2018
@MaikKlein
Copy link
Member

I actually implemented it right now #137

@SiebenCorgie
Copy link
Author

SiebenCorgie commented Nov 3, 2018

That was fast, I just tested it and it works. So I close the issue since the pull request will be merged later I guess.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants