Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any reason for not having descriptorIndexing extension not having it's own type? #856

Closed
GummyGun opened this issue Jan 7, 2024 · 5 comments

Comments

@GummyGun
Copy link

GummyGun commented Jan 7, 2024

I would like to know if there is any reason in particular to not having this implemented descriptorIndexing.
I know that, ExtDescriptorIndexingFn exists but I am curious about this is it because it is a newer extension?
This small change will help keep the interface consistant.

@Ralith
Copy link
Collaborator

Ralith commented Jan 7, 2024

What extension do you think is missing? "descriptorIndexing" is not the name of a Vulkan extension. VK_EXT_descriptor_indexing is, and it has a struct.

@GummyGun
Copy link
Author

GummyGun commented Jan 7, 2024

I was referring to about a struct inside the ash::extensions::ext module, maybe it would be kind of a small struct since there are no associated functions to the extension that would require the instantiation of the struct but you could at least call ash::extensions::ext::DescriptorIndexing::name()

@Ralith
Copy link
Collaborator

Ralith commented Jan 7, 2024

Again, which extension do think is missing a struct? What is its name?

@MarijnS95
Copy link
Collaborator

MarijnS95 commented Jan 7, 2024

The consistency is that extensions without functions do not have a hand-written extension wrapper in ash::extensions::<vendor>::<extname>. You can always use vk::ExtDescriptorIndexingFn::name() instead.

Maybe this might change when the layout of extensions, functions and wrappers is restructured in the bindings.


EDIT:

This small change will help keep the interface consistant.

There are many function-less extensions, this would be a rather massive undertaking.

@MarijnS95 MarijnS95 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2024
@MarijnS95
Copy link
Collaborator

We've refactored the layout of extension modules completely in #894, in the next release all names will be available under ash::<prefix>::<extension name>::NAME regardless of the existence of a hand-written high-level helper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants