Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X.com links considered as invalid #36

Closed
cmdrGuyson opened this issue May 28, 2024 · 2 comments
Closed

X.com links considered as invalid #36

cmdrGuyson opened this issue May 28, 2024 · 2 comments

Comments

@cmdrGuyson
Copy link
Contributor

x.com links are considered as invalid as they do not pass the regex used for link validation

https://github.com/ashwamegh/react-link-preview/blob/master/src/components/LinkPreview.js#L16-L21

The validation considers a link is valid if there are 2 - 256 characters. This should be changed to allow 1 character as well

image
@cmdrGuyson cmdrGuyson mentioned this issue May 28, 2024
Merged
@cmdrGuyson
Copy link
Contributor Author

@ashwamegh I created a PR to address this, want to know your thoughts as to why this was kept as a 2 -256 character validation initially.

@ashwamegh
Copy link
Owner

Hey @cmdrGuyson I have merged it, Thanks for identifying & fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashwamegh @cmdrGuyson