Fix escape

asika32764 · asika32764 · commit b706a2cf7c2c · 2024-05-24T16:29:21.000+08:00
diff --git a/phpunit.ci.xml b/phpunit.ci.xml
@@ -3,8 +3,6 @@
          convertErrorsToExceptions="true"
          convertNoticesToExceptions="true"
          convertWarningsToExceptions="true"
-         strict="true"
-         syntaxCheck="true"
 >
     <php>
         <ini name="error_reporting" value="-1" />
diff --git a/src/Autolink.php b/src/Autolink.php
@@ -185,7 +185,11 @@ public function link(string $url, array $attribs = []): string
         }
 
         if ($this->isAutoTitle()) {
-            $attribs['title'] = htmlspecialchars($url);
+            $attribs['title'] = htmlspecialchars(
+                $url,
+                // PHP 8.1 or higher will escape single quote
+                ENT_QUOTES | ENT_SUBSTITUTE
+            );
         }
 
         return $this->buildLink($content, $attribs);

Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,6 @@`
`3`	`3`	`convertErrorsToExceptions="true"`
`4`	`4`	`convertNoticesToExceptions="true"`
`5`	`5`	`convertWarningsToExceptions="true"`
`6`		`- strict="true"`
`7`		`- syntaxCheck="true"`
`8`	`6`	`>`
`9`	`7`	`<php>`
`10`	`8`	`<ini name="error_reporting" value="-1" />`
Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,11 @@ public function link(string $url, array $attribs = []): string`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`if ($this->isAutoTitle()) {`
`188`		`- $attribs['title'] = htmlspecialchars($url);`
	`188`	`+ $attribs['title'] = htmlspecialchars(`
	`189`	`+ $url,`
	`190`	`+ // PHP 8.1 or higher will escape single quote`
	`191`	`+ ENT_QUOTES \| ENT_SUBSTITUTE`
	`192`	`+ );`
`189`	`193`	`}`
`190`	`194`
`191`	`195`	`return $this->buildLink($content, $attribs);`