Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve strategy of finding correct default package to build. #1

Open
User344 opened this issue Nov 13, 2024 · 0 comments
Open

Improve strategy of finding correct default package to build. #1

User344 opened this issue Nov 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@User344
Copy link
Member

User344 commented Nov 13, 2024

Current strategy is to look at "default-members" of workspace section in Cargo.toml and search packages that have "bin" target in them.

The problems with this approach are next:

  • We only support building one package per action, so if there are multiple packages matching above criteria there is no way to know which one should be used. Should support for building multiple packages be added in this case?
  • We only look for "bin" targets, but "dylib", "cdylib" and other crate types also produce artifacts. Do we look for every crate type that produces artifacts when looking for potential package? It might make first problem even more visible.
@User344 User344 added enhancement New feature or request good first issue Good for newcomers and removed good first issue Good for newcomers labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant