Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullable header values bug #85

Closed
jetexe opened this issue Jan 29, 2021 · 2 comments · Fixed by #86
Closed

Nullable header values bug #85

jetexe opened this issue Jan 29, 2021 · 2 comments · Fixed by #86

Comments

@jetexe
Copy link
Contributor

jetexe commented Jan 29, 2021

Hi!

PSR-7 says that header must be string or string[] but this service sets Access-Control-Allow-Origin to null then allowedOrigins is ['*'], supportsCredentials is true and Origin header doesn't set.

I suggest to add additional check here
This was referenced Jan 29, 2021
Merged
Closed
@tarampampam
Copy link

@barryvdh can you say when fixed version will be released?)

@barryvdh
Copy link
Collaborator

https://github.com/asm89/stack-cors/releases/tag/v2.0.3 is released now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Access-Control-Allow-Origin null bug
3 participants
@barryvdh @jetexe @tarampampam