Skip to content
This repository has been archived by the owner on Oct 15, 2023. It is now read-only.

suggestions for making the format field ("M", "RM", "MR", etc) more useful #19

Open
robertmuth opened this issue Nov 23, 2021 · 0 comments

Comments

@robertmuth
Copy link

For my project (based on asmdb) it has been very useful to locally rewrite the format field to satisfy the following invariant:

  • the number of characters in the format field equals the number of operands.
    This is violated for implicit operands, e.g.:
 "div"              , "X:<edx>, X:<eax>, r32/m32"                       , "M"       , "F7 /6"

My suggestion would be to change the format field to something like: "xxM" where "x" represents an implicit operand.

There also seems to be a problem with these opcodes:

    ["mov"              , "w:r8, ib/ub"                                     , "I"       , "B0+r ib"                      , "ANY"],
    ["mov"              , "w:r16, iw/uw"                                    , "I"       , "66 B8+r iw"                   , "ANY"],
    ["mov"              , "W:r32, id/ud"                                    , "I"       , "B8+r id"                      , "ANY"],
    ["mov"              , "W:r64, iq/uq"                                    , "I"       , "REX.W B8+r iq"                , "X64"],

I believe the format should be ""OI"

@robertmuth robertmuth changed the title suggestions for make the format field ("M", "RM", "MR", etc) more useful suggestions for making the format field ("M", "RM", "MR", etc) more useful Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant