Allow API keys to be set by an environment variable

[sloria]

Use case: I'd like to add all-repos.json to source control without committing my API_KEY.

    "source_settings":  {
        "api_key": "$GITHUB_API_KEY",
        "org": "marshmallow-code"
    }

[asottile]

I don't really want to support arbitrary templating / complex configuration loading schemes (it's the reason json is chosen as the configuration format)

[sloria]

Fair enough. What about an additional option then, e.g. "api_key_var": "GITHUB_API_KEY", that is mutually exclusive of "api_key"?

[asottile]

feels like that'll open a bunch of new edge cases and error cases -- I'd really rather keep this simple, I don't think that checking in the configuration is the right answer here.

If you want templating, you could always implement it with sed or such:

sed "s/API_KEY/${API_KEY}/g" all-repos.template.json > all-repos.json

check in the template and a little wrapper script / make target / whatever and you're good to go

[asottile]

plus you'll hit this wall with git-managed files:

all-repos/all_repos/config.py

Line 38 in 252fe6f

if mode != 0o600:

[sloria]

OK, I'll just use the .template.json workaround for now. Thanks for the suggestion.

[jfly]

For anyone else who lands here, it looks like all-repos does now have support for reading API key from env vars =) b3d2d9e