Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save bazel commands that will be run to a log file #94

Open
JesseTatasciore opened this issue Jan 6, 2022 · 4 comments
Open

Save bazel commands that will be run to a log file #94

JesseTatasciore opened this issue Jan 6, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@JesseTatasciore
Copy link
Member

  • Everytime the aspect-cli runs a bazel command we should save it to a log file (useful for debugging, learning, etc)
  • Everytime the aspect-cli run we should inform the user where they can find the log of bazel commands (should add a config option to disable this as well in case the user does not want this to happen)
@JesseTatasciore JesseTatasciore added this to the 1.0 milestone Jan 6, 2022
@JesseTatasciore JesseTatasciore self-assigned this Jan 27, 2022
@alexeagle
Copy link
Member

alexeagle commented Jan 27, 2022

Use an off-the-shelf logger library. Name a directory with an aspect-generated invocation ID, then it contains /aspect.log, /plugin1.log, /crash.log, /command.log etc
Maybe also another file which is an index of the invocations we ran.
Prevent logs growing on disk forever.

Make it easy for us to log more things from more places.
Thulio has ideas of what API to use to expose the logger, maybe it goes through the ctx

Plugins should each get their own log file.

@alexeagle
Copy link
Member

@alexeagle
Copy link
Member

We can have log levels in the API, but let's just set the level to DEBUG always for now, with no user affordance to change it. Can revisit later. Generally we'd like more data available for us to diagnose issues rather than less.

@alexeagle
Copy link
Member

Maybe use https://pkg.go.dev/log/syslog if it meets our requirements?
logstash? humio?

https://www.humio.com/log-management/
https://www.elastic.co/logstash/

@mattem mattem added the enhancement New feature or request label Mar 21, 2022
@JesseTatasciore JesseTatasciore linked a pull request May 2, 2022 that will close this issue
@gregmagolan gregmagolan removed this from the CLI MVP - Release 1.0.0 milestone Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants