Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Wrong placement of output files for ts_proto_library #466

Open
jvliwanag opened this issue Oct 12, 2023 · 1 comment
Open

[Bug]: Wrong placement of output files for ts_proto_library #466

jvliwanag opened this issue Oct 12, 2023 · 1 comment
Labels
bug Something isn't working funding needed Contribute to https://opencollective.com/aspect-build help wanted Aspect isn't prioritizing this, but the community could

Comments

@jvliwanag
Copy link

jvliwanag commented Oct 12, 2023 •
edited
Loading

What happened?

ts_proto_library should write its output on the directory the rule was defined.

Release 4.5.0 however writes the output instead on the directory where the proto file is.

Version

Development (host) and target OS/architectures: macos

Output of bazel --version: aspect 5.7.2

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: 4.5.0

Language(s) and/or frameworks involved: rules_ts

How to reproduce

Create a ts_proto_library where the proto file is on a different directory + BUILD.

See sample commit from sample branch.

Any other information?

No response
@jvliwanag jvliwanag added the bug Something isn't working label Oct 12, 2023
@github-actions github-actions bot added the untriaged Requires traige label Oct 12, 2023
@alexeagle alexeagle added help wanted Aspect isn't prioritizing this, but the community could funding needed Contribute to https://opencollective.com/aspect-build and removed untriaged Requires traige labels Jan 24, 2024
@alexeagle
Copy link
Member

Yeah that looks like a simple pathing bug in computing the output path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working funding needed Contribute to https://opencollective.com/aspect-build help wanted Aspect isn't prioritizing this, but the community could
Projects
Open Source
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexeagle @jvliwanag