Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aspect configure doesn't pick up tsconfig.json files #507

Open
bgdnvk opened this issue Dec 19, 2023 · 4 comments
Open

[Bug]: aspect configure doesn't pick up tsconfig.json files #507

bgdnvk opened this issue Dec 19, 2023 · 4 comments
Labels
bug Something isn't working repro needed Repro needed to proceed further

Comments

@bgdnvk
Copy link

bgdnvk commented Dec 19, 2023

What happened?

I'm using aspect configure to make my build files, it picks up dependencies fine but doesn't include a ts_config anywhere.

My project is fairly complex: a monorepo with several frontends with microfrontends (React and Webpack) and backend services in Go. Go build works fine with Gazelle.

Version

Development (host) and target OS/architectures: Ubuntu 22.04 LTS

Output of bazel --version: 7.0.0

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: Module

Language(s) and/or frameworks involved: TS, React, Webpack, Monorepo and Microfrontends

How to reproduce

No response

Any other information?

I've tried to check different examples, blog posts and there wasn't no luck in slack.

No response

@bgdnvk bgdnvk added the bug Something isn't working label Dec 19, 2023
@github-actions github-actions bot added the untriaged Requires traige label Dec 19, 2023
@alexeagle alexeagle added repro needed Repro needed to proceed further and removed untriaged Requires traige labels Dec 19, 2023
@alexeagle
Copy link
Member

Can you provide more detail on how to reproduce, and how the generated BUILD file differs from what you expect? As I pointed out on slack, we have a bunch of test coverage for tsconfig handling.

@bgdnvk
Copy link
Author

bgdnvk commented Dec 21, 2023

I will try to give more examples later but the BUILD file doesn't add the ts_config rules (maybe I worded my question wrong), another answer from slack providing: # gazelle:js_tsconfig enabled generated it for some files. The build fails if you don't have a ts_config rule with a tsconfig path so I was wondering if this is a bug because adding it manually to every file doesn't seem like the right approach.

@alexeagle
Copy link
Member

Sorry, this is still not enough detail on how to reproduce, what you see and what you expect.

@jbedard
Copy link
Member

jbedard commented Feb 27, 2024

@bgdnvk is it the generation of ts_config rules or ts_project(tsconfig) attributes that you are not getting? Note that anything tsconfig related is still in an initial trial and will be enhanced more in the future. I believe today it only discovers tsconfig.json (no other filenames like tsconfig.tests.json etc).

The ts_project(tsconfig) attribute will now be generated though, within the supported use cases at least. See aspect-build/aspect-cli#633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working repro needed Repro needed to proceed further
Projects
Status: No status
Development

No branches or pull requests

3 participants