Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: ts_proto_library should use an aspect and run over transitive proto deps #628

Open
mrmeku opened this issue Jun 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mrmeku
Copy link
Contributor

mrmeku commented Jun 18, 2024

What is the current behavior?

Currently, ts_proto_library produces files for the direct proto dep it is passed. This is unideal since it forces users to both vendor in all transitive proto libraries they need typescript support for, and also manually link together a tree of ts_proto_library and js_libraries which mirrors the exact structure of the proto dependencies themselves

Describe the feature

Ideally, ts_proto_library would run an aspect over all transitive dependencies such that only one ts_proto_library target needs to be authored by the user. The write_source_files implementation would likely need to be rethought out for third party proto dependencies at that point

@mrmeku mrmeku added the enhancement New feature or request label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant