-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support translations in the debug log #169
Comments
Lots of translations for debug log related functionality coming up in #168 |
Logs are usually not translated, we can't translate the coding language so why do it for logs. |
Aren't there some static strings like message prefixes? |
Yes a couple of them like API rerouted Do you think they should be translated? |
@afragen what do you think? |
Default API Found: %s These three are the only ones. |
I've never translated error logs. |
These are static labels inside the error logs, not the logs themselves. |
I've just found most error logs are all English so I didn't see the point of translating labels. |
The content most likely is but the labels are static fields which should be translated. Setting a level of completeness here --- the static labels may be other English words eventually that are less technical. |
Making them translatable should be fine. |
It's important to clearly identify which parts need translation. We should consider whether the value of these new strings justifies the potential barrier they might pose for new contributors in a specific language. Additionally, should the required percentage of translation completion before release be adjusted? An initial check shows over 30 strings needing translation, with these examples. And there are likely many more.
Edit by @costdev: Used triple backticks to encompass the example so it's a single code block. |
btw we should take input from #polyglots about this |
Are we proceeding with this one? |
I see the following strings that could be translated: includes/class-api-rewrite.php
includes/class-debug.php
The rest appear to be array keys, object properties, values, or types like Does anyone see any other log-related strings that could/should be translated? |
I have checked the following:
Describe the feature you want to add
As far as I know there are no translations in the debug log.
Mockups or Images of the feature
Nothing to add at this time. Would be nice to have debug log messages translated.
The text was updated successfully, but these errors were encountered: