Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi site support #59

Closed
ipajen opened this issue Oct 28, 2024 — with Slack · 9 comments · Fixed by #102
Closed

Multi site support #59

ipajen opened this issue Oct 28, 2024 — with Slack · 9 comments · Fixed by #102
Assignees
Labels
enhancement New feature or request

Comments

Copy link
Collaborator

ipajen commented Oct 28, 2024

  1. Go to https://playground.wordpress.net/?blueprint-url=https%3A%2F%2Fraw.githubusercontent.com%2Faspirepress%2FAspireUpdate%2Frefs%2Fheads%2Fplayground-ready%2Fassets%2Fplayground%2Fblueprint.json

  2. Go to settings and creste a multi site Network

  3. Go to Network admin dashboard

/wp-admin/network/update-core.php has updates but no AP.

/wp-admin/index.php?page=aspireupdate-settings has AP but no updates

Expected that the AP menu would be in multi site Network instead.

@asirota
Copy link
Member

asirota commented Oct 28, 2024

Can you please add some screen shots on what you are describing?

@ipajen
Copy link
Collaborator Author

ipajen commented Oct 28, 2024

IMG_8500
IMG_8501
IMG_8502

@asirota
Copy link
Member

asirota commented Oct 28, 2024

I see. The AU settings doesn't appear under multisite. Glad you are using playgrounds to test. It saves tons of time.

@asirota asirota self-assigned this Oct 28, 2024
@asirota asirota added this to the 0.5 milestone Oct 28, 2024
@asirota asirota added the enhancement New feature or request label Oct 28, 2024
@asirota asirota modified the milestones: 0.5, Phase 1 Oct 29, 2024
@namithj
Copy link
Contributor

namithj commented Oct 29, 2024

This one is a bit tricky.

There are two ways to do this

  1. Show the AspireUpdate settings on each site under a multisite. - Which is easy to implement but its pretty much useless as updates are usually handled by network-admin

  2. Create a new settings page just for multisite under network admin saving the options to network-settings instead of individual site options and make it apply to all sub sites. This will be the proper way to handle it but will take more work to get it done and we will have to test everything on both places once this is done.

Need to decide whether we want to take this up for V1

@asirota
Copy link
Member

asirota commented Oct 29, 2024

I would say kick this to a subsequent Phase of the project post the launch. I cannot tell how many websites use multisite but the biggest one is WordPress.com.

@asirota asirota removed this from the Phase 1 milestone Oct 29, 2024
@ipajen
Copy link
Collaborator Author

ipajen commented Oct 29, 2024

Some stats
https://trends.builtwith.com/widgets/WordPress-Multisite

If not included in phase1 it would be great to add info on docs about it.

@asirota
Copy link
Member

asirota commented Oct 29, 2024

About 2M out of 400+M sites use Multisite. I think if there is a particularly important site that wants to use AspirePress we would jump on this, but not quite yet.

@namithj
Copy link
Contributor

namithj commented Oct 29, 2024

I think those sites can still use the wp-config.php way to configure the plugin and the plugin needs to be globally activated by the network admin

Need to test and verify.

@afragen
Copy link
Contributor

afragen commented Nov 2, 2024

I have a PR. It assumes that AspireUpdate should be network activated on multisite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants