Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use namespace specified in project system \ MSBuild to calculate default namespace for components #5106

Closed
pranavkm opened this issue Nov 16, 2018 · 3 comments
Closed

Use namespace specified in project system \ MSBuild to calculate default namespace for components #5106

pranavkm opened this issue Nov 16, 2018 · 3 comments
Assignees
@ajaybhargavb
Labels
area-blazor Includes: Blazor, Razor Components Components Big Rock This issue tracks a big effort which can span multiple issues Done This issue has been fixed feature-razor-pages
Milestone
3.0.0-preview4

Comments

@pranavkm
Copy link
Contributor

The current code uses the path to calculate the base namespace for RazorComponents. We should instead use the RootNamespace property specified in MSBuild
@aspnet-hello aspnet-hello transferred this issue from aspnet/Razor Dec 14, 2018
@aspnet-hello aspnet-hello added this to the 3.0.0-preview2 milestone Dec 14, 2018
@aspnet-hello aspnet-hello added 1 - Ready area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-razor-pages labels Dec 14, 2018
@nvmkpk
Copy link

nvmkpk commented Dec 20, 2018 •
edited
Loading

This also applies to blazor applications. It, I believe, uses the same tool.

@SteveSandersonMS SteveSandersonMS added the area-blazor Includes: Blazor, Razor Components label Feb 6, 2019
@ajaybhargavb ajaybhargavb assigned ajaybhargavb and unassigned rynowak Feb 23, 2019
@ajaybhargavb ajaybhargavb mentioned this issue Feb 23, 2019
Merged
@ajaybhargavb
Copy link
Contributor

Assigning this to myself as I'm working on it now.

@ajaybhargavb
Copy link
Contributor

Closing as this is done pending merge to master.

@ajaybhargavb ajaybhargavb added Done This issue has been fixed and removed 2 - Working labels Feb 28, 2019
@rynowak rynowak mentioned this issue Mar 4, 2019
Closed
56 tasks
@ajaybhargavb ajaybhargavb mentioned this issue Mar 4, 2019
Closed
@rynowak rynowak added the Components Big Rock This issue tracks a big effort which can span multiple issues label Mar 13, 2019
@mkArtakMSFT mkArtakMSFT removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels May 9, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
area-blazor Includes: Blazor, Razor Components Components Big Rock This issue tracks a big effort which can span multiple issues Done This issue has been fixed feature-razor-pages
Projects
None yet
Milestone
3.0.0-preview4
Development

No branches or pull requests
8 participants
@pranavkm @SteveSandersonMS @rynowak @ajaybhargavb @danroth27 @nvmkpk @mkArtakMSFT @aspnet-hello