Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SignalR Service usage an aspect of deployment, not source code #5629

Closed
SteveSandersonMS opened this issue Nov 6, 2018 · 3 comments
Closed
Assignees
Labels
area-blazor Includes: Blazor, Razor Components Components Big Rock This issue tracks a big effort which can span multiple issues Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one

Comments

@SteveSandersonMS
Copy link
Member

For Razor Components (currently, server-side Blazor), the decision to use Azure SignalR Service or not shouldn't be hardcoded into the app code. Ideally it would be something determined by the deployment mechanism.

Somehow we need sufficient abstraction to remove this from the project source code. The tricky bit is that we don't want to bring in a dependency on Microsoft.Azure.SignalR for all projects, so I'm not sure how we solve this.

I seem to recall that @DamianEdwards mentioned this is just a one example of a broader class of requirements to make service usage determined by the deployment/hosting mechanism. So perhaps this is not something we need to solve in this repo, because we're going to inherit a broader solution that applies to all services. CC @davidfowl.

@davidfowl
Copy link
Member

cc @anurse @bradygaster Something we need to change in SignalR itself.

@bradygaster
Copy link
Member

Precisely my thinking when i invited the tooling team to our original discussion, as they'll eventually need to be involved. What i don't know [yet] is if we also need to involve someone on the Kudu and/or Azure DevOps sides. I will begin to find out now, so we're prepared. Also we should factor this into our considerations for the 3.0 milestone.

@aspnet-hello aspnet-hello transferred this issue from dotnet/blazor Dec 17, 2018
@aspnet-hello aspnet-hello added this to the Backlog milestone Dec 17, 2018
@aspnet-hello aspnet-hello added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-blazor Includes: Blazor, Razor Components labels Dec 17, 2018
@rynowak
Copy link
Member

rynowak commented Mar 18, 2019

@davidfowl - I know you're working on this - is there another item that tracks this?

@mkArtakMSFT mkArtakMSFT added the Components Big Rock This issue tracks a big effort which can span multiple issues label Apr 19, 2019
@rynowak rynowak mentioned this issue Apr 19, 2019
56 tasks
@mkArtakMSFT mkArtakMSFT modified the milestones: Backlog, 3.0.0-preview6 Apr 19, 2019
@danroth27 danroth27 added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Apr 25, 2019
@mkArtakMSFT mkArtakMSFT removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels May 9, 2019
@mkArtakMSFT mkArtakMSFT assigned danroth27 and unassigned rynowak May 17, 2019
@danroth27 danroth27 added the Done This issue has been fixed label May 21, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components Components Big Rock This issue tracks a big effort which can span multiple issues Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Development

No branches or pull requests

7 participants