Platform database benchmarks broken

[sebastienros]

Error trying to populate database cache: System.ArgumentOutOfRangeException: 'dueTime' must be less than or equal to '4294967294'. (Parameter 'dueTime')
Actual value was 4294967295.
  at System.ArgumentOutOfRangeException.ThrowGreater[T](String paramName, T value, T other)
  at System.Threading.TimerQueueTimer.GetMilliseconds(TimeSpan time, String parameter)
  at System.Threading.TimerQueueTimer.Change(TimeSpan dueTime, TimeSpan period)
  at System.Threading.CancellationTokenSource.CancelAfter(UInt32 millisecondsDelay)
  at System.Threading.CancellationTokenSource.CancelAfter(TimeSpan delay)
  at Npgsql.Util.ResettableCancellationTokenSource.Stop()
  at Npgsql.Internal.NpgsqlWriteBuffer.Flush(Boolean async, CancellationToken cancellationToken)
  at Npgsql.Internal.NpgsqlConnector.RawOpen(SslMode sslMode, NpgsqlTimeout timeout, Boolean async, CancellationToken cancellationToken, Boolean isFirstAttempt)
  at Npgsql.Internal.NpgsqlConnector.<Open>g__OpenCore|213_1(NpgsqlConnector conn, SslMode sslMode, NpgsqlTimeout timeout, Boolean async, CancellationToken cancellationToken, Boolean isFirstAttempt)
  at Npgsql.Internal.NpgsqlConnector.Open(NpgsqlTimeout timeout, Boolean async, CancellationToken cancellationToken)
  at Npgsql.PoolingDataSource.OpenNewConnector(NpgsqlConnection conn, NpgsqlTimeout timeout, Boolean async, CancellationToken cancellationToken)
  at Npgsql.PoolingDataSource.<Get>g__RentAsync|28_0(NpgsqlConnection conn, NpgsqlTimeout timeout, Boolean async, CancellationToken cancellationToken)
  at Npgsql.NpgsqlConnection.<>c__DisplayClass166_0.<<StartBindingScope>g__StartBindingScopeAsync|0>d.MoveNext()

[sebastienros]

/cc @roji

[vonzshik]

There was a change around timers in dotnet/runtime#83604. Might be the reason?

[sebastienros]

@vonzshik definitely related, this exception is a new behavior from this PR, thanks

[sebastienros]

This seems to be triggered by this https://github.com/npgsql/npgsql/blob/43a2e983f41aced973d7071eb0fdbea1ca7a8773/src/Npgsql/Util/ResettableCancellationTokenSource.cs#L169

[vonzshik]

Yep. Also notice that it casts from TimeSpan to UInt32 - this probably is the reason:

at System.Threading.CancellationTokenSource.CancelAfter(UInt32 millisecondsDelay)
  at System.Threading.CancellationTokenSource.CancelAfter(TimeSpan delay)
  at Npgsql.Util.ResettableCancellationTokenSource.Stop()

[sebastienros]

Agreed, because the checks are the same (ArgumentOutOfRangeException.ThrowIfGreaterThan)

[vonzshik]

I took a closer look. There is a thing called UnsignedInfinite which is used by the timer as infinite timeout. And it seems because TimerQueueTimer.Change now accepts TimeSpan and tries to validate it (without accounting for uint to TimeSpan conversion) we get the exception.

[sebastienros]

Can you comment on the PR to let them know?

[vonzshik]

Sure.

[DamianEdwards]

This is fixed now.