feat: control SSL protocol version on tls jobs #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeagleGross
requested review from
adityamandaleeka,
sebastienros and
BrennanConroy
I think we should not add more jobs, but simply run TLS1.3 when we would want to compare the perf. It feels like we are adding too many jobs at a moment if we would want to multiply by TLS / OpenSSL version (x3 jobs). |
BrennanConroy
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an ability to specify the tls version for the job.
In case of Kestrel, added an option to do it on server side. In case of HTTP.SYS the only available option is to modify the underlying registry (which is unsafe and can fail / leave machine in a transient state). So the easiest is to explicitly set the
SslProtocolsproperty on the client causing server to establish a connection using specified tls protocol version.the option
load.httpClient.variables.sslProtocolsis being contributed here: dotnet/crank#786 (current PR should be merged after the crank one)