Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskHelpers_WaitWithTimeout_ReturnsTimeoutResultIfTaskNotComplete fails on xplat #43

Open
pranavkm opened this issue Mar 8, 2017 · 4 comments

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Mar 8, 2017

[xUnit.net 00:00:03.9067481]     Microsoft.VisualStudio.Web.BrowserLink.TaskHelpersTest.TaskHelpers_WaitWithTimeout_ReturnsTimeoutResultIfTaskNotComplete [FAIL]
[xUnit.net 00:00:03.9089484]       Task did not time out
Test Run Failed.

[xUnit.net 00:00:03.9092846]       Expected: True
[xUnit.net 00:00:03.9094667]       Actual:   False
[xUnit.net 00:00:03.9105680]       Stack Trace:

@YangLyu89, I'll skip it on xplat for now. Feel free to investigate it.

@JunTaoLuo
Copy link
Contributor

This test is also flaky on Windows machines. I have seen failures on Win2008 and Win2012

@JunTaoLuo
Copy link
Contributor

Skipping in e270041 Please investigate the test failure and re-enable.

@Eilon
Copy link
Member

Eilon commented Apr 10, 2018

@jodavis - does anyone need to take a look at this issue? Are we missing important coverage because this test is disabled?

@jodavis
Copy link
Contributor

jodavis commented Apr 11, 2018

No, we're not missing important coverage. It's probably not a product issue, just that the timeout needs to be increased to account for weird task timing in the test runner. I'll have someone fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants