Skip to content
This repository has been archived by the owner on Nov 22, 2018. It is now read-only.

API review updates for CORS #41

Closed
Eilon opened this issue Oct 2, 2015 · 2 comments
Closed

API review updates for CORS #41

Eilon opened this issue Oct 2, 2015 · 2 comments
Assignees
Milestone

Comments

@Eilon
Copy link
Member

Eilon commented Oct 2, 2015

In particular, a lot of types need to move out of the Cors.Core namespace. The main Cors namespace should have the most commonly used types, and plumbing can go into a sub-namespace.

@Eilon Eilon self-assigned this Oct 2, 2015
@Eilon Eilon added this to the 1.0.0-rc1 milestone Oct 2, 2015
@Eilon Eilon assigned kichalla and unassigned Eilon Oct 3, 2015
@Eilon Eilon changed the title API review for CORS API review updates for CORS Oct 3, 2015
@Eilon
Copy link
Member Author

Eilon commented Oct 3, 2015

Met with @kichalla @rynowak and @danroth27 with these conclusions:

  • Merge both packages into Microsoft.AspNet.Cors.
    • The current package separation in practice provided very little value, and unfortunately was self-defeating with respect to the original purpose of having two packages: to encourage developers using MVC to use just the parts MVC needed. Unfortunately it was most common to reference the both packages transitively anyway (which was harmless, but unnecessary)
  • Move DisableCorsAttribute and EnableCorsAttribute into .Cors namespace
  • Move all other types from both original assemblies (including CorsMiddleware and CorsPolicyBuilder) into .Infrastructure namespace.
  • Post announcement that links back to this issue

@davidfowl
Copy link
Member

Nice

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants