Merge relational and regular table docs #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
MergeRelational
branch
7 times, most recently
from
947b957
to
4bccb9a
Compare
|
@roji What's the state here? There is a lot of conversation above between you and Diego; do these still need to be resolved? |
|
Yep, I'm planning to pick this up again now that we're done with 3.1. It would be good to get another opinion on the state of the PR as-is before I do. |
roji
force-pushed
the
MergeRelational
branch
5 times, most recently
from
d67c08a
to
ba46584
Compare
|
@ajcvickers (and @aspnet/efteam in general) I rebased this and did some minor tweaks, but otherwise left as-is. Take a look at Diego's comments and tell me what you think. Once we establish how we want it to be I'll go and do the same to the rest of the modeling docs. |
smitpatel
reviewed
Dec 5, 2019
smitpatel
reviewed
Dec 5, 2019
|
Pushed some changes. |
roji
force-pushed
the
MergeRelational
branch
2 times, most recently
from
23497ad
to
8744336
Compare
AndriySvyryd
reviewed
Dec 9, 2019
AndriySvyryd
approved these changes
Dec 9, 2019
* Merged modeling/relational/tables and modeling/relational/default-schema into modeling/included-types and renamed to types-and-tables. * Show DataAnnotation/FluentAPI as tabs Part of #1669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1669
Notes/questions:
The configuration in this section is applicable to relational databases in general. The extension methods shown here will become available when you install a relational database provider (due to the shared Microsoft.EntityFrameworkCore.Relational package)). As we're merging relational and non-relational docs, it seems OK to remove this note, and to textually call out when documenting a relational-only feature.