Clarify some statements in the owned entity types docs #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
reviewed
Nov 8, 2019
|
Should we explicitly call out that owned types are not a good replacement for complex types and do not closely match the semantics for DDD-style value objects? |
|
@ajcvickers I think we need to provide a better alternative first (multi-column value converters) for the warning to be effective. |
AndriySvyryd
force-pushed
the
Issue1239
branch
from
7051608 to
6ff7ef5
Compare
ajcvickers
approved these changes
Nov 11, 2019
|
@ajcvickers And if you make this remark, then, please,explain, why it is not a good fit for DDD ;-) I am also eagerly watinig for the feature to setup aggregate shape, so Includes are called automatically. That's actually the main reason why I use owned types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1239
Fixes #1400
Fixes #1457
Fixes #1628
Fixes #1629
Fixes #1781
Fixes #1888