Automatically include *.edmx files in SDK-style projects

[bricelam]

Fixes #891

[bricelam]

@pranavkm @javiercn Any gotchas?

[javiercn]

I’d recommend having buildTransitive pros to point to buildMultitargeting prod and that to build props.

I think you added the elements correctly AFAIK I don’t remember if there were 2 flags or 1 for content, as 1 for default items and a more specific one for web content.

WRT msbuild im not sure if you need to compare against 'True' or 'true'. I always do the latter, but not sure if it matters.

[javiercn]

Looks great!

[CZEMacLeod]

It would be useful to have an EF6 specific property to turn this behavior off. I use CodeFirst and Migrations, but also extract the target EDMX from the migration resource file and set it to be parented to the migration. This means that I can easily look at the generated model visually and check if it is correct or use it for reference, print it, share it with my team etc.
With this change (and I think something in VS2019 when it adds EDMX files now even with EF6.2) I have to effectively override this and set all my EDMX 'reference' files back to None.
Maybe we could use the standard Migrations or Migrations.* folders as an exclusion?

[bricelam]

@javiercn AFAICT, buildMultitargeting is only needed to affect restore and pack. These are effectively embedded resources so they only matter when compiling for a specific framework.

MSBuild is case insensitive. I like to channel my inner VB developer when writing conditions since it's And not &&.

I'll add an off switch for edmx files similar to the existing ones. This should enable @CZEMacLeod's scenario

[javiercn]

@javiercn AFAICT, buildMultitargeting is only needed to affect restore and pack. These are effectively embedded resources so they only matter when compiling for a specific framework.

That's fair. I normally do the chaining transitive -> multitargeting -> build because its safe in all situations.

MSBuild is case insensitive. I like to channel my inner VB developer when writing conditions since it's And not &&

It's fair

I'll add an off switch for edmx files similar to the existing ones. This should enable @CZEMacLeod's scenario

This is a good thing to have. The razor SDK also does it.

[bricelam]

Oh I guess the other place where you need multitargeting is when you have an entry-point target. Otherwise msbuild /t:MyTarget wouldn't work on multi-targeting projects.

[bricelam]

Updated. @CZEMacLeod add this to your project to prevent it from happening by default (you'll still be able to manually change them to EntityDeploy items if you want)

<PropertyGroup>
  <EnableDefaultEntityDeployItems>False</EnableDefaultEntityDeployItems>
</PropertyGroup>