Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RevEng: Why do we scaffold product version? #13809

Closed
bricelam opened this issue Oct 30, 2018 · 1 comment · Fixed by #15657
Closed

RevEng: Why do we scaffold product version? #13809

bricelam opened this issue Oct 30, 2018 · 1 comment · Fixed by #15657
Assignees
@bricelam
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.0.0

Comments

@bricelam
Copy link
Contributor

Is it intentional that we scaffold this line?

modelBuilder.HasAnnotation("ProductVersion", "2.2.0-preview3-35497");
@ajcvickers
Copy link
Member

Bug--it shouldn't be there.

@ajcvickers ajcvickers added this to the 3.0.0 milestone Oct 31, 2018
ErikEJ added a commit to ErikEJ/EntityFramework that referenced this issue May 8, 2019
@ErikEJ
Stop scaffolding productversion
20dad3d 
fixes dotnet#13809
@ErikEJ ErikEJ mentioned this issue May 8, 2019
Merged
ajcvickers pushed a commit that referenced this issue May 8, 2019
@ErikEJ @ajcvickers
Stop scaffolding productversion
cbefe76 
fixes #13809
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 8, 2019
@ajcvickers ajcvickers mentioned this issue May 9, 2019
Closed
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview6 Jun 5, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview6, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Stop scaffolding productversion ErikEJ/EntityFramework
2 participants
@bricelam @ajcvickers