Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compliance tests should make sure that the derived class are also public #15336

Closed
smitpatel opened this issue Apr 12, 2019 · 0 comments · Fixed by #15344
Closed

Compliance tests should make sure that the derived class are also public #15336

smitpatel opened this issue Apr 12, 2019 · 0 comments · Fixed by #15344
Assignees
@roji
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.0.0

Comments

@smitpatel
Copy link
Contributor

Internal derived class would make it look like tests are there but internal class wouldn't run tests.
@ajcvickers ajcvickers added this to the 3.0.0 milestone Apr 12, 2019
roji added a commit to roji/efcore that referenced this issue Apr 12, 2019
@roji
Compliance tests now fail on non-public test classes
0483a2c 
Closes dotnet#15336
@roji roji mentioned this issue Apr 12, 2019
Merged
roji added a commit to roji/efcore that referenced this issue Apr 12, 2019
@roji
Compliance tests now fail on non-public test classes
b333c16 
Closes dotnet#15336
roji added a commit that referenced this issue Apr 12, 2019
@roji
Compliance tests now fail on non-public test classes
786aea1 
Closes #15336
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 15, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview4 Apr 15, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview5 Apr 22, 2019
@ajcvickers ajcvickers mentioned this issue Apr 25, 2019
Closed
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview5, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Compliance tests now fail on non-public test classes roji/efcore
3 participants
@ajcvickers @smitpatel @roji