Microsoft.Data.Sqlite: Improve SqliteDataReader.GetFieldType() when NULL #14315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this. Will this make it into the next release? |
|
Haven’t had a chance to review it yet. It will make it into 3.0.0, but not the next preview. Also, I’m still not sure if we want TEXT or BLOB to be the ultimate fallback. |
bricelam
suggested changes
Mar 18, 2019
bricelam
approved these changes
Mar 25, 2019
bricelam
reviewed
Mar 25, 2019
|
(Rebased on top of master) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a column value is NULL, SqliteDataReader.GetFieldType() now tries to return the field type based on the column affinity.
SQLite does not provide the affinity via its API, therefore the corresponding C function sqlite3AffinityType was ported to C#. The affinity NUMERIC has no corresponding data type, so here the data type TEXT is returned (as suggested as default in #13831).
A special case is a column where no type is specified, here the explicit rule was used, that such a column is of affinity BLOB (see Determination Of Column Affinity).
The corresponding changes were also introduced for the SqliteDataReader.GetSchemaTable() DataType column.
Fixes #13831 and fixes #13839