Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nameof syntax in scaffolding data annotations attributes #14609

Merged
merged 1 commit into from
May 10, 2019
Merged

Added nameof syntax in scaffolding data annotations attributes #14609

merged 1 commit into from
May 10, 2019

Conversation

Muppets
Copy link
Contributor

@Muppets Muppets commented Feb 4, 2019

Summary of the changes

  • Switched up ForeignKeyAttribute and InversePropertyAttribute to use nameof() syntax
  • Added InversePropertyAttribute into code generation unit test

Fixes #11744

@smitpatel smitpatel self-assigned this Feb 6, 2019
@bricelam
Copy link
Contributor

bricelam commented Feb 6, 2019

Blocked on investigating the maximum version of C# we can use (#14545)

@Muppets
Copy link
Contributor Author

Muppets commented May 9, 2019

As reminded here: #11744 (comment), worth merging this now?

@bricelam bricelam removed the blocked label May 10, 2019
@bricelam bricelam merged commit 1cb4021 into dotnet:master May 10, 2019
@bricelam bricelam self-assigned this May 10, 2019
@ajcvickers ajcvickers mentioned this pull request May 16, 2019
Closed
@Muppets Muppets deleted the issue11744 branch February 2, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel left review comments

@bricelam bricelam Awaiting requested review from bricelam

Assignees

@bricelam bricelam

@smitpatel smitpatel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RevEng: Use nameof in data annotations
3 participants
@Muppets @bricelam @smitpatel