Query: Fix potential re-use of QuerySqlGen from multiple threads #15880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/racecondition
branch
from
682115c to
aa89c3b
Compare
Due to internal state, it causes corruption of generated Sql command The fix is to pass factory and generate SqlGen when we are enumerating. Also fixed logging when connection opening failed in query Fix build break
smitpatel
force-pushed
the
smit/racecondition
branch
from
aa89c3b to
5226170
Compare
ajcvickers
approved these changes
May 31, 2019
ghost
deleted the
This was referenced May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to internal state, it causes corruption of generated Sql command
The fix is to pass factory and generate SqlGen when we are enumerating.
Also fixed logging when connection opening failed in query