Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Enable parameter & sproc support for FromSql #15890

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Conversation

smitpatel
Copy link
Contributor

Adds optimizer to optimize SelectExpression before printing based on ParameterValues
TODO: Add a factory through service to avoid multiple services here. This also serves point for us to determine second level caching

Lift FromSqlExpression when not composed over to avoid subquery which is necessary for stored procedures
Add additional enumerables which add remapping map to materialize non composed SelectExpression which can have out of order projections

Resolves#15750

@smitpatel
Copy link
Contributor Author

Filed #15891 #15893

@smitpatel smitpatel requested review from roji and maumar and removed request for roji June 1, 2019 00:52
@smitpatel smitpatel changed the base branch from smit/collectionInclude to master June 1, 2019 01:15
@smitpatel smitpatel requested a review from roji June 1, 2019 01:18
Adds optimizer to optimize SelectExpression before printing based on ParameterValues
TODO: Add a factory through service to avoid multiple services here. This also serves point for us to determine second level caching

Lift FromSqlExpression when not composed over to avoid subquery which is necessary for stored procedures
Add additional enumerables which add remapping map to materialize non composed SelectExpression which can have out of order projections

Resolves#15750
Copy link
Contributor

@maumar maumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I't would be nice for a second pair of eyes to look at this

@smitpatel smitpatel merged commit e311f44 into master Jun 1, 2019
@ghost ghost deleted the smit/fromsql branch June 1, 2019 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryRewrite: parameter support for FromSql()
2 participants