Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value converter for Uri #15900

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Value converter for Uri #15900

merged 1 commit into from
Jun 3, 2019

Conversation

Muppets
Copy link
Contributor

@Muppets Muppets commented Jun 2, 2019

Summary of the changes

  • Added StringUriConverter and unit tests
  • Added Uri selection to ValueConverterSelector

Fixes #15816

@Muppets
Copy link
Contributor Author

Muppets commented Jun 2, 2019

@maumar I would like to add a model with Uri type to validate the end to end test of this converter. Any suggestions on where to put that model unit test?

@ajcvickers ajcvickers merged commit 730fbc0 into dotnet:master Jun 3, 2019
@ajcvickers
Copy link
Member

Thanks @Muppets!

@maumar
Copy link
Contributor

maumar commented Jun 3, 2019

@Muppets CustomConvertersTestBase would be a good place to put the tests

@ajcvickers ajcvickers mentioned this pull request Jun 6, 2019
Closed
@Muppets Muppets deleted the 15816-Value-converter-for-Uri branch February 2, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Value converter for Uri
3 participants
@Muppets @ajcvickers @maumar