Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target netstandard2.1 #15918

Merged
merged 4 commits into from
Jun 4, 2019
Merged

Target netstandard2.1 #15918

merged 4 commits into from
Jun 4, 2019

Conversation

smitpatel
Copy link
Contributor

@smitpatel smitpatel commented Jun 3, 2019

Microsoft.Data.Sqlite & EF tools are left intact.
Most of the changes are related to breaking change on interface which IX-Async gave us and which is in built
Resolves #15498

@smitpatel
Copy link
Contributor Author

@bricelam - If any changes required on tools packages
cc @roji for benchmark effects.

Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename these directories too:

  • src/EFCore.Tools/lib/netstandard2.0/
  • src/EFCore.Sqlite/lib/netstandard2.0/

Otherwise, LGTM

@bricelam
Copy link
Contributor

bricelam commented Jun 4, 2019

No additional changes (besides my previous comment) are required to the tools package since it still has to work with 2.x projects.

Microsoft.Data.Sqlite & EF tools are left intact.
Most of the changes are related to breaking change on interface which IX-Async gave us and which is in built
@smitpatel
Copy link
Contributor Author

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target .NET Standard 2.1
2 participants