Fix to #15535 - Query: Navigation rewrite does not preserve the type of result #15951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
commented
Jun 4, 2019
| @@ -343,12 +346,12 @@ protected override Expression VisitBinary(BinaryExpression binaryExpression) | |||
| { | |||
| var navigationKeyAccessExpression = NavigationExpansionHelpers.CreateKeyAccessExpression( | |||
| navigationBindingExpression, | |||
| navigationBindingExpression.EntityType.FindPrimaryKey().Properties, | |||
| new[] { navigationBindingExpression.EntityType.FindPrimaryKey().Properties.First() }, | |||
There was a problem hiding this comment.
this entire code will be removed once entity equality is in
maumar
force-pushed
the
fix15535
branch
2 times, most recently
from
9a836f0
to
ed0057d
Compare
…of result Problem was that we were only storing generic method definition for cardinality reducing operators (First/Single) because nav rewrite changes source types a lot. However, those operators are applied after pending selector, so they are guaranteed to be of the same type as originally. We only need to track the changes that happen e.g. during member pushdown, e.g.: customers.FirstOrDefault<Customer>().Id is changed to customers.Select(c => c.Id).FirstOrDefault<int>()
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was that we were only storing generic method definition for cardinality reducing operators (First/Single) because nav rewrite changes source types a lot.
However, those operators are applied after pending selector, so they are guaranteed to be of the same type as originally. We only need to track the changes that happen e.g. during member pushdown, e.g.:
customers.FirstOrDefault().Id is changed to customers.Select(c => c.Id).FirstOrDefault()