Switch to using the BCL HashCode type #16069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove allocations from GetHashCode() methods by refraining from using LINQ.
Notes:
Aggregate()
(or other LINQ) since we don't really wantGetHashCode()
to allocate.HashCode
there as well?base.GetHashCode()
, I simply passed that valueHashCode.Combine()
in the subclass. That means double-hashing occurs, which I think should be OK (opinions/insights??). Otherwise we'd need to expose getting aHashCode
instance from base classes (not even possible with base classes we don't own, e.g. Expression).