Fixing some small bugs in sql generation #16112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maumar
commented
Jun 15, 2019
maumar
commented
- removing redundant term in Contains translation with constant argument,
- fixing logic around IN sql gen,
- clean up logic around de morgan optimization,
- adding new optimization op(a, b) == true -> op(a, b),
- removing a number of tests that are no longer relevant due to query pipeline changes.
maumar
commented
Jun 15, 2019
|
|
||
|
|
There was a problem hiding this comment.
seems that we are no longer removing whitespaces here - is that expected?
smitpatel
reviewed
Jun 15, 2019
src/EFCore.Relational/Query/Pipeline/InExpressionValuesExpandingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Query/Pipeline/SqlExpressionOptimizingVisitor.cs
Outdated
Show resolved
Hide resolved
maumar
force-pushed
the
some_sqlgen_fixes
branch
from
37643f7 to
e9b9fb0
Compare
|
new version up |
smitpatel
reviewed
Jun 18, 2019
| SqlExpressionFactory = sqlExpressionFactory; | ||
| } | ||
|
|
||
| protected QueryCompilationContext QueryCompilationContext { get; private set; } |
There was a problem hiding this comment.
Expose only useRelationalNulls?
smitpatel
approved these changes
Jun 18, 2019
- removing redundant term in Contains translation with constant argument, - fixing logic around IN sql gen, - clean up logic around de morgan optimization, - adding new optimization op(a, b) == true -> op(a, b), - removing a number of tests that are no longer relevant due to query pipeline changes.
maumar
force-pushed
the
some_sqlgen_fixes
branch
from
e9b9fb0 to
aafc355
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.