Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos: Add API to configure partition keys and use them in the update pipeline. #16148

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

AndriySvyryd
Copy link
Member

Fix Northwind tests

Part of #12086

@AndriySvyryd AndriySvyryd requested a review from smitpatel June 19, 2019 01:23
CancellationToken cancellationToken = default)
{
using (var stream = new MemoryStream())
using (var writer = new StreamWriter(stream, new UTF8Encoding(), bufferSize: 1024, leaveOpen: false))
using var stream = new MemoryStream();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:trollface:

@smitpatel
Copy link
Contributor

Can you rebase on latest master and make sure SimpleQueryTests are passing?

@AndriySvyryd
Copy link
Member Author

AndriySvyryd commented Jun 19, 2019

@smitpatel Where_subquery_anon is still failing. Is that expected?

System.NotImplementedException : The method or operation is not implemented.
Stack Trace:
at CosmosQueryableMethodTranslatingExpressionVisitor.TranslateSelectMany(ShapedQueryExpression source, LambdaExpression collectionSelector, LambdaExpression resultSelector) in CosmosQueryableMethodTranslatingExpressionVisitor.cs line: 326
at QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in QueryableMethodTranslatingExpressionVisitor.cs line: 337
at QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in QueryableMethodTranslatingExpressionVisitor.cs line: 32
at QueryableMethodTranslatingExpressionVisitor.VisitMethodCall(MethodCallExpression methodCallExpression) in QueryableMethodTranslatingExpressionVisitor.cs line: 32
at QueryCompilationContext.CreateQueryExecutor[TResult](Expression query) in QueryCompilationContext2.cs line: 62
at Database.CompileQuery[TResult](Expression query, Boolean async) in Database.cs line: 72
at QueryCompiler.CompileQueryCore[TResult](IDatabase database, Expression query, IModel model, Boolean async) in QueryCompiler.cs line: 108
at <>c__DisplayClass12_01.<ExecuteAsync>b__0() in QueryCompiler.cs line: 141 at CompiledQueryCache.GetOrAddQueryCore[TFunc](Object cacheKey, Func1 compiler) in CompiledQueryCache.cs line: 84
at CompiledQueryCache.GetOrAddQuery[TResult](Object cacheKey, Func1 compiler) in CompiledQueryCache.cs line: 59 at QueryCompiler.ExecuteAsync[TResult](Expression query, CancellationToken cancellationToken) in QueryCompiler.cs line: 137 at EntityQueryProvider.ExecuteAsync[TResult](Expression expression, CancellationToken cancellationToken) in EntityQueryProvider.cs line: 98 at EntityQueryable1.GetAsyncEnumerator(CancellationToken cancellationToken) in EntityQueryable.cs line: 112 at ConfiguredCancelableAsyncEnumerable1.GetAsyncEnumerator()
at EntityFrameworkQueryableExtensions.ToListAsync[TSource](IQueryable1 source, CancellationToken cancellationToken) in EntityFrameworkQueryableExtensions.cs line: 2133 at EntityFrameworkQueryableExtensions.ToArrayAsync[TSource](IQueryable1 source, CancellationToken cancellationToken) in EntityFrameworkQueryableExtensions.cs line: 2164
at QueryAsserter1.AssertQuery[TItem1,TItem2](Func3 actualQuery, Func3 expectedQuery, Func2 elementSorter, Action`2 elementAsserter, Boolean assertOrder, Int32 entryCount, Boolean isAsync, String testMethodName) in QueryAsserter.cs line: 403
at SimpleQueryCosmosTest.Where_subquery_anon(Boolean isAsync) in SimpleQueryCosmosTest.cs line: 440

@smitpatel
Copy link
Contributor

Disable the test in Cosmos

@smitpatel
Copy link
Contributor

Those are the tests @maumar enabled in core so need to disable them in cosmos.

@AndriySvyryd AndriySvyryd merged commit af247a8 into master Jun 19, 2019
@ghost ghost deleted the PartitionKeys branch June 19, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants