Query: Add builtIn flag to SqlFunction and use it to quoting logic #16166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuctions without arguments passed considered niladic. Non-niladic functions without arguments must pass empty array of args. Functions with instance are considered built in. Functions without schema are considered built in. Functions with schema are non-built-in (Schema can be null) To map a DbFunction to built-in function use HasTranslation API Resolves #12757 Resolves #14882 Resolves #15501
AndriySvyryd
approved these changes
Jun 19, 2019
roji
reviewed
Jun 21, 2019
src/EFCore.Relational/Query/Pipeline/SqlExpressions/SqlFunctionExpression.cs
Show resolved
Hide resolved
roji
approved these changes
Jun 21, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuctions without arguments passed considered niladic.
Non-niladic functions without arguments must pass empty array of args.
Functions with instance are considered built in.
Functions without schema are considered built in.
Functions with schema are non-built-in (Schema can be null)
To map a DbFunction to built-in function use HasTranslation API
Resolves #12757
Resolves #14882
Resolves #15501