[TINY] Fix to #16245 - Null semantics applies incorrectly for SqlFunction #16266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Jun 26, 2019
src/EFCore.Relational/Query/Pipeline/NullSemanticsRewritingVisitor.cs
Outdated
Show resolved
Hide resolved
|
updated |
smitpatel
reviewed
Jun 26, 2019
| @@ -171,6 +171,7 @@ private CaseExpression VisitCaseExpression(CaseExpression caseExpression) | |||
|
|
|||
| private SqlFunctionExpression VisitSqlFunctionExpression(SqlFunctionExpression sqlFunctionExpression) | |||
There was a problem hiding this comment.
CaseExpression may also need reset since Operand can be null.
problem was that when we were computing a nullability of sql function, if the function didn't have instance, we would inherit nullability from the expression that was visited previously. Fix is to only use nullability of instance expression if that expression is not null.
|
@AndriySvyryd - I added commit here to address the PR feedback. Can you give sign-off? |
AndriySvyryd
approved these changes
Jun 28, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem was that when we were computing a nullability of sql function, if the function didn't have instance, we would inherit nullability from the expression that was visited previously.
Fix is to only use nullability of instance expression if that expression is not null.