Cosmos: Fix reference nested owned entities in queries #16276
Conversation
|
@smitpatel Could you check whether this is the correct approach? |
| _materializationContextBindings[parameterExpression] = Expression.Convert( | ||
| CreateReadJTokenExpression(_jObjectParameter, projection.Alias), | ||
| typeof(JObject)); | ||
| _materializationContextBindings[parameterExpression] = _jObjectParameter; |
There was a problem hiding this comment.
Does this work when you have projected out multiple entities in projection
There was a problem hiding this comment.
It should. Is there a test for that?
| shaperBody = new CosmosProjectionBindingRemovingExpressionVisitor(selectExpression, jObjectParameter) | ||
| .Visit(shaperBody); | ||
| var jObjectParameter = Expression.Parameter(typeof(JObject), "jObject"); | ||
| var shaperBody = new CosmosProjectionBindingRemovingExpressionVisitor(selectExpression, jObjectParameter, this) |
There was a problem hiding this comment.
Can we keep injecting materializer and binding removal separate?
We can have another visitor which inject nested entityshapers
There was a problem hiding this comment.
That was my original design, but we need to add the jObject variable before each materializer is injected.
src/EFCore.Cosmos/Query/Pipeline/CosmosShapedQueryCompilingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
force-pushed
the
CosmosOwned
branch
from
b0f3ac7 to
309bcb9
Compare
AndriySvyryd
changed the title
AndriySvyryd
force-pushed
the
CosmosOwned
branch
from
309bcb9 to
125ec92
Compare
AndriySvyryd
force-pushed
the
CosmosOwned
branch
from
125ec92 to
6bfeedc
Compare
|
@smitpatel Updated |
|
It would be good to have EntityShaper not worry about nested part and at some point before compiling, we injected nested entityShaper in the tree directly. (possibly re-using includeExpression), |
|
Ok, I'll check this in as is and try that while adding collection support. |
ghost
deleted the
No description provided.